Do not fetch user status if current user is a guest #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user status endpoint is not available for guests, only for logged in users. As the request will always fail if the current user is a guest there should be no need to perform it. Note, however, that this will prevent user statuses to be shown on the avatars in public share pages, even if the current user is actually logged in. Public share pages are opened in ncognito mode, so "getCurrentUser" returns null. However, if the current user is logged in requests to the API would work without problems, so technically it would be possible to fetch the user statuses. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
bug
danxuliu
requested review from
nickvergessen,
georgehrke,
ChristophWurst,
skjnldsv and
marcoambrosini
juliusknorr
approved these changes
Sep 3, 2020
|
@georgehrke Not sure if there were plans about making status endpoints available for public access? |
skjnldsv
approved these changes
Sep 3, 2020
skjnldsv
added
4. to release
No, not at the moment |
georgehrke
approved these changes
Sep 3, 2020
georgehrke
deleted the
do-not-fetch-user-status-if-current-user-is-a-guest
branch
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Sep 3, 2020
Ref nextcloud-libraries/nextcloud-vue#1379 Signed-off-by: Joas Schilling <coding@schilljs.com>
|
I know, this is already merged, but: Avoid loading the user status for non users is developed in the avatar component (#1348). For guests it is developed in the status component. This looks inconsistent. Shouldn't this be solved together in the same app component? |
|
Those are 2 different things. #1348 is to not try to render a status for an avatar of non users. This here is because guests will never be able to load any status info for others (atm), independent from which component the request is coming from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user status endpoint is not available for guests, only for logged in users. As the request will always fail if the current user is a guest there should be no need to perform it.
Note, however, that this will prevent user statuses to be shown on the avatars in public share pages, even if the current user is actually logged in. Public share pages are opened in incognito mode, so
getCurrentUserreturns null. However, if the current user is logged in requests to the API would work without problems, so technically it would be possible to fetch the user statuses.Due to the problem described in last paragraph I am not sure if this should be merged or not. In fact the more I think about it the less I like this pull request :-P Opinions?