Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't close modal on mouseup #1647

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

marcoambrosini
Copy link
Contributor

@marcoambrosini marcoambrosini commented Dec 23, 2020

fix: #1645

Signed-off-by: Marco Ambrosini marcoambrosini@pm.me

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini added bug Something isn't working 3. to review Waiting for reviews labels Dec 23, 2020
@marcoambrosini marcoambrosini self-assigned this Dec 23, 2020
@marcoambrosini marcoambrosini added the feature: modal Related to the modal component label Dec 23, 2020
@skjnldsv skjnldsv merged commit b1e14dc into master Dec 29, 2020
@skjnldsv skjnldsv deleted the bugfix/1645/dont-close-modal-on-mouseup branch December 29, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: modal Related to the modal component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mouseup events shouldn't close the modal component
3 participants