Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong parameter type in registerFunction #171

Closed
herki84 opened this issue Oct 10, 2022 · 1 comment · Fixed by #194
Closed

Wrong parameter type in registerFunction #171

herki84 opened this issue Oct 10, 2022 · 1 comment · Fixed by #194

Comments

@herki84
Copy link

herki84 commented Oct 10, 2022

registerFunction in impersonate.js takes an integer as parameter, but document.addEventListener('DOMContentLoaded', registerFunction) supplies an event.
If OCA.Setting is not set at this point, script execution halts due to delay = delay * 2 not working on an object.

Should be an easy fix by including isNaN(delay)
@solracsf
Copy link
Member

PRs are welcome 😜

@blizzz blizzz mentioned this issue Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix unexpected parameter to callback nextcloud/impersonate
2 participants
@solracsf @herki84