New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Psalm CI #744

Closed

nickvergessen opened this issue Sep 26, 2022 · 2 comments · Fixed by #1105

Labels

3. to review bug

Member

nickvergessen commented Sep 26, 2022

Psalm and the OCP package are already there, but it is not run on CI

nickvergessen added bug 3. to review labels

Tas-sos commented Nov 29, 2022

Do you mean on GitHub actions here : https://github.com/nextcloud/firstrunwizard/tree/master/.github/workflows ?

Member Author

nickvergessen commented Nov 29, 2022 •

edited

Loading

Yes. There are some more files needed like

psalm.xml
- https://github.com/nextcloud/notifications/blob/master/psalm.xml
tests/psalm-baseline.xml
- https://github.com/nextcloud/notifications/blob/master/tests/psalm-baseline.xml
- (Should be emptied and then populated with new entries if the issues can not be fixed)
composer with the package and commands:
- https://github.com/nextcloud/notifications/blob/master/composer.json#L28-L31
- https://github.com/nextcloud/notifications/blob/master/composer.json#L14

The workflow can be copied from https://github.com/nextcloud/.github/blob/master/workflow-templates/psalm.yml

susnux mentioned this issue

feat: Add psalm workflow and adjust code #1105

Merged

susnux closed this as completed in #1105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment