Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock folder without token leads to 404 #479

Closed
tobiasKaminsky opened this issue Jul 3, 2023 · 4 comments
Closed

Unlock folder without token leads to 404 #479

tobiasKaminsky opened this issue Jul 3, 2023 · 4 comments
Assignees
@artonge
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working

Comments

@tobiasKaminsky
Copy link
Member

  • have an encrypted folder
  • DELETE lock without passing token as header
    --> returns 404

Instead it should give a better error message
@tobiasKaminsky tobiasKaminsky added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Jul 3, 2023
@artonge
Copy link
Collaborator

artonge commented Jul 3, 2023

Not authorised ?

@tobiasKaminsky
Copy link
Member Author

No. According to API it needs token, which is okay.
But 404 is then misleading.
Better would be a 412 precondition failed, with info that token is missing.

@artonge artonge self-assigned this Jul 5, 2023
@artonge
Copy link
Collaborator

artonge commented Jul 5, 2023 •
edited
Loading

First part server side:

@artonge artonge mentioned this issue Jul 17, 2023
Merged
@artonge
Copy link
Collaborator

artonge commented Aug 31, 2023

Change done in #405

@artonge artonge closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artonge artonge

Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working
Projects
📁 Files team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tobiasKaminsky @artonge