Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this note still true? #9004

Open
p-bo opened this issue Jul 4, 2022 · 3 comments
Open

Is this note still true? #9004

p-bo opened this issue Jul 4, 2022 · 3 comments

Comments

@p-bo
Copy link
Contributor

p-bo commented Jul 4, 2022

In
https://github.com/nextcloud/documentation/blob/master/user_manual/files/sharing.rst
There is stated:

Note
Password protection as well as file expiration are not propagated using Federated File Sharing in current Nextcloud releases. This will be adjusted in Nextcloud 22.

Is this resolved? If not, now we are on version 24, so what version to state there for now please?

Thanks

@tflidd
Copy link
Contributor

tflidd commented Jul 10, 2022

The related pull request was merged: nextcloud/server#25320

@tflidd
Copy link
Contributor

tflidd commented Aug 18, 2022

@PVince81 you did the PR, can you help out for the documentation if this point was resolved?

@PVince81
Copy link
Member

the PR doesn't technically propagate expiration. it just makes it so that the originating share might expire and when it does, it's as if it was deleted, so federated instances that connect to it will detect it on next access. from a higher point of view it might look like it's propagated.

passwords aren't propagated, so perhaps we can remove the part of the note about expiration date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants