Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically suspend synchronization of a disappeared group folder: avoid deleting currently synced files #7013

Open
ferdiga opened this issue Aug 21, 2024 · 4 comments
Labels
enhancement enhancement of a already implemented feature/code hotspot: group folders Group folders is factor stable-3.13 Feedback on 3.13.x releases

Comments

@ferdiga
Copy link

ferdiga commented Aug 21, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you want to have the same feature implemented.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature description

this proposed solution deleted all synced data of the group folders - some 150GB - in my case
nextcloud/fulltextsearch#858 (comment)

I suggest to check the size of the deleted files and propose to ask "Do you really want to delete xxxGB"

It's just the reverse situation of checking/asking if the client should download large directories.

@ferdiga ferdiga added the enhancement enhancement of a already implemented feature/code label Aug 21, 2024
@joshtrichards joshtrichards added the hotspot: group folders Group folders is factor label Aug 21, 2024
@mgallien
Copy link
Collaborator

@ferdiga I do not get what you are asking for.
Are you suggesting that under some conditions, files no longer available on the server must not be deleted by the sync client ?
That would result in a subsequent upload by the client. If I understand the original problem correctly, the given user would now have a copy of the group folder in their own personal storage space. That may not be desirable.

Please note that for storage that may temporarily be unavailable, there is a way to handle this and in fact the client would pause the sync of a given folder that is reported as not mounted by the server.

Just being absent, will cause upload to your personal storage and I doubt that this is what most users would want.

@mgallien mgallien changed the title disable group folders deletes all synced files automatically suspend synchronization of a disappeared group folder: avoid deleting currently synced files Aug 23, 2024
@mgallien
Copy link
Collaborator

I took on me to rename the issue to not sound like a bug (especially since you added the enhancement label).
When we speak about files being deleted, people tend to be over reactive.

@ferdiga
Copy link
Author

ferdiga commented Aug 23, 2024

what happened:

  • group folders have been disabled
  • client sync deleted immediately some 100GB, as group folders vanished
  • after enabling the group folders again some 100GB have been downloaded again. Was not a problem on high capacity connection

this is obviously a correct behaviour.

Nevertheless IMO the client should ask if the files should be deleted or if this is only temporary outage.

The problem seems that if no server is available, the sync is paused, but in this case the server was available.

@joshtrichards
Copy link
Member

Related: #6099

@joshtrichards joshtrichards added the stable-3.13 Feedback on 3.13.x releases label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement of a already implemented feature/code hotspot: group folders Group folders is factor stable-3.13 Feedback on 3.13.x releases
Projects
None yet
Development

No branches or pull requests

3 participants