Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in description after the attachment is deleted #518

Open
cloud2018 opened this issue Jul 3, 2018 · 2 comments
Open

Broken link in description after the attachment is deleted #518

cloud2018 opened this issue Jul 3, 2018 · 2 comments

Comments

@cloud2018
Copy link
Contributor

cloud2018 commented Jul 3, 2018

Describe the bug
In the description of a card the link of an inserted attachment is broken, after the attachment is deleted

To Reproduce

  1. Attach a file to a card
  2. Insert the attachment (test_attachment.txt) into description
  3. Delete the attachment
  4. Wait until the attachment is finally deleted and the icon for undelete is disappeared
  5. Open the card and click on the link "???? test_attachment.txt", which refers to (/nextcloud/apps/deck/cards/188/attachment/42)
  6. The nextcloud errorpage "Internal Server Error; The server was unable to complete your request.; If this happens again, ..." is displayed

Expected behavior
In the description is only the text "???? test_attachment.txt" or "???? missing attachment: test_attachment.txt" and no clickable link, which refers to the deleted file

Tested with
0.4.0-beta3

Note
Perhaps the behavior depends on the extension of the deleted file. With textfiles there is a broken link, with images it is just like expected "???? test_attachment.jpg" (without link)


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@juliusknorr
Copy link
Member

Seems to be a good improvement. But we need to take care we don't change the description but only show a hint about the missing attachment. Maybe a tooltip on the link would be a good option there.

@stale

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants