Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview images are not shown when attaching images #952

Closed
DavidMndz opened this issue Oct 17, 2023 · 5 comments
Closed

Preview images are not shown when attaching images #952

DavidMndz opened this issue Oct 17, 2023 · 5 comments
Labels
bug Something isn't working upstream

Comments

@DavidMndz
Copy link

DavidMndz commented Oct 17, 2023

Describe the bug
When you are attaching an image into a Collective, it does not show the preview of the image in the select menu as it was before. It happens the same inserting from Files (Nextcloud) or from computer.

To Reproduce
Steps to reproduce the behavior:

  1. Open a collective in Edit mode.
  2. Insert an image from Files
  3. Search for the picture you want to attach.
  4. The previews are not shown.

Expected behavior
The preview of the image should be shown, otherwise it is very difficult to know the photo you select.

Screenshots
If applicable, add screenshots to help explain your problem.

Client details:

  • OS: Debian and Android
  • Browser: Brave
  • Version: Latest
  • Device: Pixel 7 Pro and desktop
Server details

Collectives app version: 2.8.2

Operating system: Debian

Web server: Apache2

Database: myswl

PHP version: 8.2

Nextcloud version: 27.1.2

Logs

No errors are reported in logs.

Nextcloud log (data/nextcloud.log)

Insert your Nextcloud log here

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...
@DavidMndz DavidMndz added the bug Something isn't working label Oct 17, 2023
@mejo-
Copy link
Member

mejo- commented Nov 8, 2023

Dear @DavidMndz, thanks for your report. Can you please provide a screenshot of the problem? The dialog that's opened by "Upload from computer" is provided by your browser and not specific to Nextcloud. Unfortunately we cannot do anything about this dialog. But the "Insert from files" dialog is Nextcloud specific. I'd need a screenshot to better understand your problem though.

@DavidMndz
Copy link
Author

Hello @mejo- ,

thanks for checking the issue.

I was testing again and I can see the same issue with the files that I try to attach from my computer or from the Nextcloud files directly. I attach the screenshot from the option 'Attach from Nextcloud files'.

Screenshot from 2023-11-08 14-41-11

I hope this clarifies, if you need further details let me know please. Also, if you could please give it a try on your side to see if in your installation it happens the same, I think it could be useful.

Thanks again!

@mejo-
Copy link
Member

mejo- commented Nov 8, 2023

Now I see, you mean Nextclouds file picker. The file picker indeed changed recently in Nextcloud 27.1. Apparently the new version doesn't display previews any longer. This would need to get changed in nextcloud-libraries/dialogs.

@mejo-
Copy link
Member

mejo- commented Nov 8, 2023

This already got fixed upstream in nextcloud-libraries/nextcloud-dialogs#1015, but a new stable4 release of nextcloud-libraries/dialogs is needed.

@mejo- mejo- added upstream and removed needs info labels Nov 8, 2023
@DavidMndz
Copy link
Author

Thank you very much for the assistance! I am glad it is already addresed and it is only a matter of time for getting the updated code through a new release.

@mejo- mejo- closed this as completed in 81297c1 Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

2 participants