Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot know if a CLI admin did an action or a member #606

Closed
nickvergessen opened this issue Jun 1, 2021 · 2 comments · Fixed by #609
Closed

Cannot know if a CLI admin did an action or a member #606

nickvergessen opened this issue Jun 1, 2021 · 2 comments · Fixed by #609

Comments

@nickvergessen
Copy link
Member

We need to be able to differentiate mutliple different cases for the Talk integration:

  • If user A was added to a circle by user B in the contacts app => user B
  • If user A was added to a circle via CLI => null/cli
  • If user A was invited to a circle by user B and user A accepts the invite => user B
  • If user A was invited to a circle via CLI and user A accepts the invite => null/cli
  • If user A joins a public circle => user A
  • If user A requests to join a circle and user B approved => user B
  • If user A requests to join a circle and it is approved via CLI => null/cli
@ArtificialOwl
Copy link
Member

#609 adds Member::getInvitedBy() that returns a FederatedUser with details. use ./occ circles:members:list circleId --output=json for more details about it

This will not work nice on GlobalScale, I need to store remote FederatedUser on local instance for better coverage. This should not be an issue on big setup as the circles_member table is not use for request out of the Circles Management (front-end, occ command)

@ArtificialOwl
Copy link
Member

We can see that the occ command get its own singleId :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants