Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping colors in calendar color picker and unused choose button #6145

Closed
1 of 2 tasks
Tracked by #80
ChristophWurst opened this issue Jul 11, 2024 · 4 comments · Fixed by #6200
Closed
1 of 2 tasks
Tracked by #80

Overlapping colors in calendar color picker and unused choose button #6145

ChristophWurst opened this issue Jul 11, 2024 · 4 comments · Fixed by #6200
Assignees
Labels
2. developing Work in progress bug design Related to design, interface, interaction design, UX, etc.

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Jul 11, 2024

Steps to reproduce

  1. Open the app
  2. Open the edit modal of a calendar
  3. Click the calendar color

Expected behavior

Good design

Actual behaviour

image

  • Overlapping bubbles
  • Choose does not do anyhting

Calendar app version

4.8

CalDAV-clients used

No response

Browser

No response

Client operating system

No response

Server operating system

No response

Web server

None

Database engine version

None

PHP engine version

None

Nextcloud version

No response

Updated from an older installed version or fresh install

None

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response

@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of bug design Related to design, interface, interaction design, UX, etc. labels Jul 11, 2024
@st3iny
Copy link
Member

st3iny commented Jul 16, 2024

For reference, this is how it looks on 29:

Palette Advanced
Bildschirmfoto_20240716_094126 Bildschirmfoto_20240716_094142

@ChristophWurst
Copy link
Member Author

Choose does not do anyhting

It is because of nextcloud-libraries/nextcloud-vue#5499. @susnux I'm not sure how apps should handle the submit event in the simple mode of the color picker. The app can process the selection but it can't close the picker, can it?

@st3iny
Copy link
Member

st3iny commented Jul 24, 2024

The open state can be controlled from the outside via the shown prop or synced via shown:sync. The prop is currently not documented as it is passed down to NcPopover via v-bind.

So we could add an open state variable showColorPicker to data and listen to the submit event to actually apply the color.

Example

<NcColorPicker :shown.sync="showColorPicker" @submit="setColor">...</NcColorPicker>

@st3iny st3iny changed the title Overlapping colors in calendar color picker Overlapping colors in calendar color picker and unused choose button Jul 24, 2024
@GVodyanov GVodyanov self-assigned this Jul 24, 2024
@ChristophWurst
Copy link
Member Author

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug design Related to design, interface, interaction design, UX, etc.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants