Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long WebCal URL not accepted #325

Closed
dadosch opened this issue Jan 31, 2017 · 6 comments · Fixed by #409
Closed

Long WebCal URL not accepted #325

dadosch opened this issue Jan 31, 2017 · 6 comments · Fixed by #409
Assignees
Labels
3. to review Waiting for reviews bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@dadosch
Copy link

dadosch commented Jan 31, 2017

Steps to reproduce

  1. Insert a long url to the web calendar abonement box
    i.e. from moodle: http://demo.moodle.net/calendar/export_execute.php?preset_what=courses&preset_time=recentupcoming&username=teacher&authtoken=35b0202e4f270c4cc9864e46dad56cb0c90ed382 (this is just to show the format, its NOT reachable on this host)
  2. this will fail

Expected behaviour

it should save the url in the database and add the calendar to the list

Actual behaviour

in nextcloud it says Fehler beim Speichern des WebCal-Kalenders (error on saving webcal calender)
in the log it complains about Data too long for column 'displayname'

Server configuration

Operating system:
Ubuntu 16.04.1
Web server:
nginx
Database:
mysql
PHP version:
7
Server version: (see your admin page)
11.0.1 (stable)
Calendar version: (see the apps page)
1.5.0
Updated from an older installed version or fresh install:
updated from older one

@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of bug labels Jan 31, 2017
@georgehrke georgehrke added this to the 1.6.0-current milestone Jan 31, 2017
@georgehrke
Copy link
Member

Thx for the bug report.

We will just have to cut of the display name at some point.

@georgehrke georgehrke added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Jan 31, 2017
@georgehrke
Copy link
Member

For the record: Displayname has a length of 100

@georgehrke georgehrke self-assigned this Mar 18, 2017
@georgehrke
Copy link
Member

Why not letting the user fill the displayName?

You can change the display name after creating it

@godfuture
Copy link

godfuture commented Apr 5, 2017

You can change the display name after creating it

Why not saving the display name first and afterwards the URL? Or both in the same time?

@georgehrke
Copy link
Member

Most public calendar links contain a name already. So why ask for it if in > 90% of the cases we can already use a proper one.

@georgehrke georgehrke added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants