Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile page #9097

Closed
tobiasKaminsky opened this issue Oct 14, 2021 · 4 comments · Fixed by #9112
Closed

Profile page #9097

tobiasKaminsky opened this issue Oct 14, 2021 · 4 comments · Fixed by #9112
Assignees

Comments

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Oct 14, 2021

On click on each avatar open bottom sheet with

  • profile: opens (public profile) page in web browser
  • mail: mailto link handled by OS
  • talk: either native app if installed or opens in web browser

Server API: in nextcloud/files-clients#1

@tobiasKaminsky tobiasKaminsky changed the title Personal page Profile page Oct 14, 2021
@tobiasKaminsky tobiasKaminsky self-assigned this Oct 19, 2021
@tobiasKaminsky
Copy link
Member Author

2021-10-20-074612

@nimishavijay for review :-)

@tobiasKaminsky
Copy link
Member Author

One question I have is how to show that there is an user profile?
It is only available for local users, so not for groups, conversations, remote users, emails.

@nimishavijay
Copy link
Member

Looks nice! Only 3 small things to add:

  • a bit of padding on top so that there is equal padding above and below the name
  • "profile" → "Profile" (capital P)
  • "Compose email" → "Send email" so that it is easier to understand :)

Also, I dunno if this is possible or if we have done this before, but could we increase the size of the size of the Profile icon by a bit (maybe increase 2px in width and height) so that it has size to the other icons? We could also decrease the size of the Talk icon instead of increase the Profile icon size. But that's a minor detail, it looks great :)

If there is no Profile visible to a user then it can be removed as an action in the list (does that answer the question about local users?)

@tobiasKaminsky
Copy link
Member Author

  • a bit of padding on top so that there is equal padding above and below the name

Changed it a bit:

image

* "profile" → "Profile" (capital P)

Are you sure about this? It is not a noun, like email, which is also lower case? If yes, then please create an issue on server repo, as clients only display what we receive from server.

Also, I dunno if this is possible or if we have done this before, but could we increase the size of the size of the Profile icon by a bit (maybe increase 2px in width and height) so that it has size to the other icons? We could also decrease the size of the Talk icon instead of increase the Profile icon size. But that's a minor detail, it looks great :)

They are all 40dp. I guess that profile just has a bit more whitespace around it and thus Talk icon looks bigger.
Indeed it seems that we had an old version of it:
image

If there is no Profile visible to a user then it can be removed as an action in the list (does that answer the question about local users?)

The question was more: how do users know that they can click on avatar icon in sharee list to see profile.
I think it is the "problem" on web: you see a list, but cannot know what is clickable:
image

In this case only avatar of "test2" is clickable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants