Download fails for files in folders with special characters

[Telefza]

Steps to reproduce

1. Create folder with a questionmark at the end, e.g. "newFolder ?"
2. Put some file in "newFolder ?"
3. Try sync from android app

Expected behaviour

• Sync the folder with the file in it

Actual behaviour

• Fails to sync.

Environment data

Android version: 11

Device model: Nokia 4.2

Stock or customized system: Stock

Nextcloud app version: 3.16.0

Nextcloud server version: 21.0.1

Reverse proxy: Nope

Logs

Android app debug output

connected phone via usb and ran:
adb logcat | grep "$(adb shell ps | awk '/com.nextcloud.client/{print $2}')" > logcatOutput.txt

This is the error I get

04-01 12:54:43.268 14157 15449 E DownloadFileRemoteOperation: Download of path/to/me/file/newFolder ?/stuff.txt: Unrecovered transport exception

[AndyScherzinger]

reproduced on master.

@tobiasKaminsky I guess we don't escape the ? in the folder-name with %3F but that is just a guess. Do you remember where we do the escaping(s)? Quick search didn't find anything useful :(

[AlvaroBrey]

Reproduced also with the : character. Same exception.

[vfosnar]

Also reproduced with < character. I guess > won't work too.

[RowhamD]

Observed, that this problem
occurs on a Pixel6 with Android 12,
does not occur on a Samsung Galaxy Tab S6 with Android 9.
(Accessing the same server nc 24.0.4 with Android-app 3.21.2)

[RowhamD]

Observed furthermore that:

• filenames are affected, too
• .txt-files and .md-files are an exeption! (If you have a .txt- or .md-file having :?<> in its path and/or filename it is possible to open them in the Android-app - maybe because the Nextcloud internal editor is used to open these files?)
• .odt- or .ods-files will
  • work, too, if CollaboraOffice is installed and you just tap on them to open CollaboraOffice
  • won't download if you choose "download" from their 3dot-menu

[twinkybot]

Yes files are afftected as well e.g. Foo: Bar - (C64#).mp3 or inverted ? or 01. ¡Chakra:Red! - Track 1.flac

[twinkybot]

Can this be upvoted?

[AlvaroBrey]

Related: #2711