diff --git a/lib/BackgroundJob/ExpireActivities.php b/lib/BackgroundJob/ExpireActivities.php index ed5f152a7..8eaa80c21 100644 --- a/lib/BackgroundJob/ExpireActivities.php +++ b/lib/BackgroundJob/ExpireActivities.php @@ -1,4 +1,6 @@ setInterval(60 * 60 * 24); + $this->setTimeSensitivity(self::TIME_INSENSITIVE); $this->data = $data; $this->config = $config; } - protected function run($argument) { + protected function run($argument): void { // Remove activities that are older then one year $expireDays = $this->config->getSystemValue('activity_expire_days', 365); $this->data->expire($expireDays); diff --git a/tests/AppInfo/ApplicationTest.php b/tests/AppInfo/ApplicationTest.php index 9ef52a5bf..0835af8d2 100644 --- a/tests/AppInfo/ApplicationTest.php +++ b/tests/AppInfo/ApplicationTest.php @@ -104,7 +104,7 @@ public function queryData(): array { [EmailNotification::class], [EmailNotification::class, TimedJob::class], [ExpireActivities::class,], - [ExpireActivities::class, TimedJob::class], + [ExpireActivities::class, \OCP\BackgroundJob\TimedJob::class], // Controller [ActivitiesController::class], @@ -131,6 +131,6 @@ public function testContainerQuery(string $service, ?string $expected = null): v if ($expected === null) { $expected = $service; } - $this->assertInstanceOf($expected, $this->container->query($service)); + $this->assertInstanceOf($expected, $this->container->get($service)); } } diff --git a/tests/BackgroundJob/ExpireActivitiesTest.php b/tests/BackgroundJob/ExpireActivitiesTest.php index 9fcbd2d05..1732d7610 100644 --- a/tests/BackgroundJob/ExpireActivitiesTest.php +++ b/tests/BackgroundJob/ExpireActivitiesTest.php @@ -28,6 +28,7 @@ use OCA\Activity\BackgroundJob\ExpireActivities; use OCA\Activity\Data; use OCA\Activity\Tests\TestCase; +use OCP\AppFramework\Utility\ITimeFactory; use OCP\IConfig; use OCP\BackgroundJob\IJobList; @@ -40,6 +41,7 @@ class ExpireActivitiesTest extends TestCase { public function testExecute(): void { $backgroundJob = new ExpireActivities( + $this->createMock(ITimeFactory::class), $this->createMock(Data::class), $this->createMock(IConfig::class) ); diff --git a/tests/DataDeleteActivitiesTest.php b/tests/DataDeleteActivitiesTest.php index bda615ef2..b910b5035 100644 --- a/tests/DataDeleteActivitiesTest.php +++ b/tests/DataDeleteActivitiesTest.php @@ -29,6 +29,7 @@ use OCA\Activity\BackgroundJob\ExpireActivities; use OCA\Activity\Data; use OCP\Activity\IExtension; +use OCP\AppFramework\Utility\ITimeFactory; use OCP\DB\IPreparedStatement; use OCP\IConfig; use OCP\IUserSession; @@ -107,10 +108,15 @@ public function testDeleteActivities(array $condition, array $expected): void { public function testExpireActivities(): void { $config = $this->createMock(IConfig::class); + $time = $this->createMock(ITimeFactory::class); + $time->method('getTime') + ->willReturn(time()); $backgroundjob = new ExpireActivities( + $time, $this->data, $config ); + $backgroundjob->setId(1); $this->assertUserActivities(['delete', 'otherUser']); $jobList = $this->createMock(IJobList::class); $backgroundjob->execute($jobList);