Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sidebar): Refactor code to also load plugin entries when Activity API returns 304 #1438

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix(sidebar): Refactor code to also load plugin entries when Activity API returns 304 #1438

merged 2 commits into from
Nov 29, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 29, 2023

We should load activities separate from other entries as 304 is no error but will throw an exception and thus skip loading extra entries (comments).

@susnux
fix(sidebar): Refactor code to also load plugin entries when Activity…
ca31c78 
… API returns 304

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the Nextcloud 28 milestone Nov 29, 2023
@susnux
Copy link
Contributor Author

susnux commented Nov 29, 2023

/backport to stable28

@susnux
chore: Compile assets
8e6827d 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 6cec440 into master Nov 29, 2023
43 checks passed
@susnux susnux deleted the fix/loading-other-entries branch November 29, 2023 18:20
@AndyScherzinger
Copy link
Member

/backport to stable28

@susnux
Copy link
Contributor Author

susnux commented Nov 30, 2023

/backport ca31c78 to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 30, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 30, 2023
@blizzz
Copy link
Member

blizzz commented Nov 30, 2023

fixed milestone. master is 29.

@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

Assignees
No one assigned
Labels
3. to review bug feature: sidebar feedback-requested
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

[Bug]: "2 new comments" but no comments
6 participants
@susnux @AndyScherzinger @blizzz @ChristophWurst @artonge @Pytal