Missing dependencies on node modules

[hschletz]

After upgrading to 7.x, webpack build failed with several messages like:

Module not found: Error: Can't resolve 'assert' in '[...]/node_modules/@nextcloud/vue/dist'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

Same for the "buffer" and "util" modules. As a workaround, I added those packages to my project:

npm install assert buffer util

The commonly suggested fallback configuration was not necessary.

Shouldn't these dependencies be handled by the nextcloud-vue package?

[ChristophWurst]

Found the same issue with nextcloud/mail#7954

       ERROR in ./node_modules/@nextcloud/vue/dist/Components/NcActions.js 2:127801-127818
      Module not found: Error: Can't resolve 'assert' in '/tmp/krankerl.x5y0zn6eHsXS/mail/node_modules/@nextcloud/vue/dist/Components'

      BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
      This is no longer the case. Verify if you need this module and configure a polyfill for it.

The app uses webpack v5.75.0

[raimund-schluessler]

I was wondering why my apps were not affected, but it's probably because they use @nextcloud/webpack-vue-config which brings a peer dependency to node-polyfill-webpack-plugin. Maybe we should add this peer dependency to @nextcloud/vue as well, so it also works without using @nextcloud/webpack-vue-config (although it's not a bad thing to use the shared webpack config 😉).

[ChristophWurst]

If this lib has a peer it expects then it should been in package.json 👍