Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Icon of AppSidebar #2804

Open
jotoeri opened this issue Jul 1, 2022 · 10 comments
Open

Change Icon of AppSidebar #2804

jotoeri opened this issue Jul 1, 2022 · 10 comments

Comments

@jotoeri
Copy link
Contributor

jotoeri commented Jul 1, 2022

As of nextcloud/forms#717, @nimishavijay proposed to change the hamurger-menu of the AppSidebar to a three-dot menu.

Afaik there were several complaints before, that the sidebar is not clearly recognized with the hamurger-menu. Thus, the three-dot menu could be a solution, might however interfer with apps having another three-dot menu next to the sidebar-icon?

@jotoeri
Copy link
Contributor Author

jotoeri commented Aug 7, 2022

Material design has the specific menu-open icon. How about using this one for the AppSidebar?
@nextcloud/designers @skjnldsv @jancborchardt @nimishavijay

icon

Screenshot from 2022-08-07 14-42-20

@raimund-schluessler
Copy link
Contributor

Would be nice to have a menu-close icon, when the menu is open. But since there isn't, maybe vertically mirror the icon🙈

@stefan-niedermann
Copy link

What about the View Sidebar material icon? 🙈
baseline_view_sidebar_black_24dp

@skjnldsv
Copy link
Contributor

Ping @jancborchardt @nimishavijay

@susnux
Copy link
Contributor

susnux commented Jun 26, 2023

Is this still relevant? The app sidebar toggle is implemented by every app so more than a recommendation for a button is not possible or am I wrong?

@nimishavijay
Copy link

The current icon used for the AppSidebar in Forms is the menu-open icon which is used as the icon for the navigation also, which can be a bit confusing. a different icon to toggle the sidebar is used in Talk (hamburger icon), Forms (menu-open), Collectives (legacy sidebar icon), Notes (not in the top right corner but in the 3dot menu of a note. Uses page-layout-sidebar-right). We should unify all of these since the sidebar has essentially the same content. Here is what seems suitable so far:

what do you think? @nextcloud/designers

@skjnldsv
Copy link
Contributor

view-sidebar or space-dashboard for me

@susnux
Copy link
Contributor

susnux commented Jun 27, 2023

Agree with skjnldsv, apps look like the grid view toggle on the files app (same position as you would expect the sidebar button).
And format-list-bulleted looks like the forms app logo, so for forms that would be a not that good.

@marcoambrosini
Copy link
Contributor

marcoambrosini commented Jun 27, 2023

What's wrong with menu-open? There's no need for a menu-close icon since we have a close button within the sidebar itself.

I would default with that but also urge developers to use their own icon so that it directly relates to the content that it's first displayed in the sidebar. For example, in talk we could display the participants icon when a call is not active, since opening the sidebar will open that tab. (In call we already have something like that and we show the chat icon)

@nimishavijay
Copy link

menu-open is used as the icon to close the navigation, so ideally we have distinct icons on the screen.
I would vote for space-dashboard because it seems more similar to the current layout of the sidebar and it's rounder, like our UI :) And agreed with the point about this being only a default and not mandatory!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants