Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace color prop of LoadingIcon with style prop #2778

Closed
raimund-schluessler opened this issue Jun 17, 2022 · 0 comments · Fixed by #2875
Closed

Replace color prop of LoadingIcon with style prop #2778

raimund-schluessler opened this issue Jun 17, 2022 · 0 comments · Fixed by #2875
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design
Milestone

Comments

@raimund-schluessler
Copy link
Contributor

How about a prop style (or similar name) with the options dark, light and auto (being default).

Yes, perfect!

@jancborchardt for 4, this what we're discussing.
You need to be able to force light or dark. See previous comments.

another one which works on the primary color (e.g. in header or buttons), depending on server theming
possibly another one in primary color which works in these new buttons we use some places which are color-primary-light. (Worst case we just use 1) for those too.)

We do not use the loading primary anywhere at nextcloud. Please provide clear guidelines on why and when to use them in an issue so we can implement this if it's really necessary 🙏

Originally posted by @skjnldsv in #2727 (comment)

@raimund-schluessler raimund-schluessler added 1. to develop Accepted and waiting to be taken care of design Design, UX, interface and interaction design labels Jun 17, 2022
@raimund-schluessler raimund-schluessler added this to the 6.0.0 milestone Jun 17, 2022
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant