Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust style of new loading icon to old loading icon #2777

Closed
raimund-schluessler opened this issue Jun 17, 2022 · 0 comments · Fixed by #2875
Closed

Adjust style of new loading icon to old loading icon #2777

raimund-schluessler opened this issue Jun 17, 2022 · 0 comments · Fixed by #2875
Assignees
@raimund-schluessler
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design discussion Need advices, opinions or ideas on this topic
Milestone
6.0.0

Comments

@raimund-schluessler
Copy link
Contributor

The new loading icon introduced in #2727 looks a bit different from the old loading icon, as it lacks the light gray full circle in the background.

Old Loading icon:
AppNavigation_before

New Loading icon:
AppNavigation_after

I wonder whether we should adjust the new loading icon components appearance to match the old style in order to unify the look while not all loading icons use the new component yet.
@jancborchardt @nimishavijay @skjnldsv What do you think?
@raimund-schluessler raimund-schluessler added design Design, UX, interface and interaction design discussion Need advices, opinions or ideas on this topic 0. to triage labels Jun 17, 2022
@raimund-schluessler raimund-schluessler added this to the 6.0.0 milestone Jun 17, 2022
@raimund-schluessler raimund-schluessler self-assigned this Jun 17, 2022
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. to triage labels Jun 28, 2022
@raimund-schluessler raimund-schluessler linked a pull request Jul 22, 2022 that will close this issue
Adjust loading icon style, replace fillColor prop #2875
Merged
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raimund-schluessler raimund-schluessler

Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design discussion Need advices, opinions or ideas on this topic
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Adjust loading icon style, replace fillColor prop nextcloud-libraries/nextcloud-vue
2 participants
@raimund-schluessler @skjnldsv