Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues after AppNavigation update #1288 #1336

Closed
3 tasks
skjnldsv opened this issue Aug 21, 2020 · 4 comments · Fixed by #1338 or #1337
Closed
3 tasks

Issues after AppNavigation update #1288 #1336

skjnldsv opened this issue Aug 21, 2020 · 4 comments · Fixed by #1338 or #1337
Assignees
@raimund-schluessler
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working design Design, UX, interface and interaction design feature: app-navigation Related to the app-navigation component high High priority regression Regression of a previous working feature

Comments

@skjnldsv
Copy link
Contributor

@raimund-schluessler so it seems the PR created some issues

Before After
Capture d’écran_2020-08-21_12-08-33 Capture d’écran_2020-08-21_12-07-26
  • Figure icon is too big
  • Compact alignment of menu is off with close button
  • Star looks off

Capture d’écran_2020-08-21_12-10-53
It also seems linkify is a bit too wild! 🦁 😁
@skjnldsv skjnldsv added bug Something isn't working 1. to develop Accepted and waiting to be taken care of feature: app-navigation Related to the app-navigation component high High priority regression Regression of a previous working feature design Design, UX, interface and interaction design labels Aug 21, 2020
@raimund-schluessler
Copy link
Contributor

Apparently, I didn't check the compact mode well enough. I will have a look.

@skjnldsv For linkify it probably is better to enable it with a prop. For filenames it will rarely make sense to have them as a link.

@skjnldsv
Copy link
Contributor Author

@skjnldsv For linkify it probably is better to enable it with a prop. For filenames it will rarely make sense to have them as a link.

I agree :)
Thanks for this!! 🤗

@raimund-schluessler raimund-schluessler mentioned this issue Aug 21, 2020
Merged
@raimund-schluessler
Copy link
Contributor

@skjnldsv If the appsidebar has no header illustration, is there any difference between compact and normal?

@skjnldsv
Copy link
Contributor Author

@skjnldsv If the appsidebar has no header illustration, is there any difference between compact and normal?

no illustration => compact :)
See original screenshots:
#340 (comment)

@skjnldsv skjnldsv linked a pull request Aug 22, 2020 that will close this issue
Fix sidebar layout in compact mode #1338
Merged
@raimund-schluessler raimund-schluessler linked a pull request Aug 22, 2020 that will close this issue
Allow to toggle linkification by prop #1337
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raimund-schluessler raimund-schluessler

Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working design Design, UX, interface and interaction design feature: app-navigation Related to the app-navigation component high High priority regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
2 participants
@raimund-schluessler @skjnldsv