Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include confirmDestructive Dialog #300

Closed
jotoeri opened this issue Feb 23, 2021 · 1 comment · Fixed by #1297
Closed

Include confirmDestructive Dialog #300

jotoeri opened this issue Feb 23, 2021 · 1 comment · Fixed by #1297
Assignees
@susnux
Labels
enhancement New feature or request
Milestone
4.3.0

Comments

@jotoeri
Copy link
Contributor

jotoeri commented Feb 23, 2021

Just wanted to use the confirmationDialog on Forms and saw i need to take it manually from OC.dialogs. Would imo be nice to have it included in this package!
@jotoeri jotoeri added the enhancement New feature or request label Feb 23, 2021
@jotoeri jotoeri mentioned this issue Feb 23, 2021
Closed
@Chartman123 Chartman123 mentioned this issue Jul 5, 2023
Merged
@susnux susnux self-assigned this Aug 10, 2023
@susnux susnux added this to the 4.2.0 milestone Aug 10, 2023
@susnux susnux modified the milestones: 4.2.0, 4.3.0 Aug 18, 2023
@susnux
Copy link
Contributor

susnux commented Aug 18, 2023

This will not make it into 4.2.0 but I think about implementing the dialogs based on the new dialog component for 5.0.0, but we could also backport this for 4.3.0 to support this on Nextcloud 27 as well.

@susnux susnux mentioned this issue Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susnux susnux

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.3.0
2 participants
@susnux @jotoeri