Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types for GoogleProfile interface #3643

Merged
merged 1 commit into from
Jan 16, 2022
Merged

Update types for GoogleProfile interface #3643

merged 1 commit into from
Jan 16, 2022

Conversation

jonbellah
Copy link
Contributor

@jonbellah jonbellah commented Jan 16, 2022 •
edited
Loading

Reasoning 💡

Match the GoogleProvider type interface to the Google documentation.

Checklist 🧢

  • Documentation
  • Tests
  • Ready to be merged

Affected issues 🎟

Fixes #3603

@github-actions github-actions bot added core Refers to `@auth/core` providers labels Jan 16, 2022
balazsorban44
balazsorban44 approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@balazsorban44 balazsorban44 merged commit d1aa2a1 into nextauthjs:main Jan 16, 2022
mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
@mnphpexpert
fix(ts): match GoogleProfile interface with Google docs (nextauthjs…
b2bb8ea 
…#3643)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

Assignees
No one assigned
Labels
core Refers to `@auth/core` providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GoogleProvider type issue when using family and given name
2 participants
@jonbellah @balazsorban44