fix: properly handle callback URL fallback #3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balazsorban44
force-pushed
the
fix/callback-url
branch
from
ea3908f
to
8b432d2
Compare
|
🎉 Experimental release published on npm! npm i next-auth@0.0.0-pr.3402.be5db520yarn add next-auth@0.0.0-pr.3402.be5db520 |
Codecov Report
@@ Coverage Diff @@
## main #3402 +/- ##
==========================================
+ Coverage 13.45% 13.47% +0.01%
==========================================
Files 90 90
Lines 1405 1403 -2
Branches 360 358 -2
==========================================
Hits 189 189
+ Misses 1205 1203 -2
Partials 11 11
Continue to review full report at Codecov.
|
mnphpexpert
added a commit
to mnphpexpert/next-auth
that referenced
this pull request
Sep 2, 2024
* fix: don't default to localhost on `host` * fall back to `host` for `callbackUrl` * use parsed host * remove unnecessary type cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3399 was a bit rushed, introduced some small bugs. Testing/Fixing them here