-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(provider): scope expects space separated string #2188
Conversation
Currently the docs list string[] as possible type for scope. However, It only accepts a string (with space as separator).
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/7bALCHjhgh2SGukGFrCtJtxnfr8u |
Thanks for the PR! I went down the rabbit hole to find the reasoning and what I found is that at the end of the day, https://nodejs.org/api/querystring.html#querystring_querystring_stringify_obj_sep_eq_options So I'm happy to accept this PR! one thing I changed is the PR target branch. We are working on our next major release, and so any non-critical changes will preferably be made in the What that means for you that until v4 docs is officially out, this change will only be visible at https://next-auth-git-next-nextauthjs.vercel.app/ for now. Hope it's not a problem for you! |
Thanks for your review! |
I was going to, but thank you! 😁 |
* fix(docs): scope expects space separated string Currently the docs list string[] as possible type for scope. However, It only accepts a string (with space as separator). Co-authored-by: Balázs Orbán <info@balazsorban.com>
Reasoning 💡
Currently the docs list string[] as a possible type for scope.
However, It only accepts a string (with space as separator).
Checklist 🧢
Affected issues 🎟