Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Nodemailer option types #807

Closed
gamedevsam opened this issue Oct 29, 2020 · 1 comment · Fixed by #2259
Closed

Missing Nodemailer option types #807

gamedevsam opened this issue Oct 29, 2020 · 1 comment · Fixed by #2259
Labels
enhancement New feature or request

Comments

@gamedevsam
Copy link

gamedevsam commented Oct 29, 2020

Summary of proposed feature
When using typescript we cannot set all node mailer options without resorting to typecasting to any.

Purpose of proposed feature
Enable setting other node mailer options like secure, authMethod, tls options, etc.

Detail about proposed feature
Either add secure type, or better yet, extend the ProviderEmailServer type to extend SMTPConnection.Options type:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/623f3889f0fac1ed3284066f990cebf3d86d1d64/types/nodemailer/lib/smtp-connection/index.d.ts#L131

Potential problems
N/A

Describe any alternatives you've considered
I casted the server field to any. A suboptimal solution.

Additional context
Any other context, screenshots, etc.
image

Please indicate if you are willing and able to help implement the proposed feature.
Probably, if time allows.

@gamedevsam gamedevsam added the enhancement New feature or request label Oct 29, 2020
@iaincollins
Copy link
Member

This sounds like a good issue for the DefinitelyTyped repo, where TypeScript definitions for NextAuth.js currently live:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/next-auth/providers.d.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants