Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong handling of email with plus #2375

Closed
ramiel opened this issue Jul 15, 2021 · 1 comment
Closed

Wrong handling of email with plus #2375

ramiel opened this issue Jul 15, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@ramiel
Copy link
Contributor

ramiel commented Jul 15, 2021

Description 🐜

When an email conatins a + like in name+something@email.com which is a valid email, the final email saved is without the + (name something@email.com).
This is because when the callback is visited this is the url http://localhost:7000/api/auth/callback/email?email=name+something@email.com&token=72544&callbackUrl=http://localhost:7000/. As you can see the email is not encoded correctly and the + get lost

Is this a bug in your own project?

No

How to reproduce ☕️

Just use an email with +. If you have a gmail account you can use youremail+whatever@gmail.com

Screenshots / Logs 📽

No response

Environment 🖥

System:
OS: Linux 5.8 KDE neon 5.22
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Memory: 1.65 GB / 15.51 GB
Container: Yes
Shell: 5.0.17 - /bin/bash
Binaries:
Node: 14.17.2 - /usr/bin/node
Yarn: 1.22.10 - ~/.npm-global/bin/yarn
npm: 6.14.13 - /usr/bin/npm
Browsers:
Brave Browser: 91.1.26.74
Chrome: 91.0.4472.114
Firefox: 89.0.2
npmPackages:
next: ^11.0.0 => 11.0.1
next-auth: ^3.27.3 => 3.27.3
react: ^17.0.2 => 17.0.2

Contributing 🙌🏽

Yes, but I need you to point me in the right direction

@ramiel ramiel added the bug Something isn't working label Jul 15, 2021
@ramiel
Copy link
Contributor Author

ramiel commented Jul 15, 2021

Not a problem on your library, it's my code. Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant