Relax test tolerance for centerline polyfit #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfhammill
changed the title
cfhammill
added
bug
jcohenadad
added
sct_get_centerline
|
This fell through the cracks. I'm going to merge it so #2698 can pass. |
Due to a singular fit for the centerline the result appears to be sensitive to platform. Relaxing the error tolerance slightly is enough to get tests passing on Ubuntu 18.04 WSL. Fixes
kousu
force-pushed
the
cfh/wsl-centerline-fix_2644
branch
from
1dd35b9
to
d8fd38c
Compare
This was referenced Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a singular fit for the centerline the result appears to be sensitive to platform. Relaxing the error tolerance slightly is enough to get tests passing on Ubuntu 18.04 WSL. Fixes #2644