Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify bashrc on sudo #2409

Merged
merged 6 commits into from
Aug 14, 2019
Merged

Conversation

gmotzespina
Copy link
Contributor

Fixes #2405

Changes

  • Removes sudo check and modifies .bashrc or respective terminal file for every type of user.

@gmotzespina gmotzespina self-assigned this Aug 14, 2019
@gmotzespina gmotzespina added card:TO_REVIEW installation category: install_sct or pip/setup.py labels Aug 14, 2019
@jcohenadad jcohenadad added this to the 4.0.1 milestone Aug 14, 2019
install_sct Outdated
echo -e $DISPLAY_UPDATE_PATH
echo -e "Then, please open a new Terminal and run sct_check_dependencies to make sure SCT is properly installed.\n"
fi
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's a good habit to add new line at the end of the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I've added the new line.

Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the new line at the end of the file, it looks good!

@gmotzespina gmotzespina merged commit 4bff9e3 into master Aug 14, 2019
@gmotzespina gmotzespina deleted the gmo/modify_bashrc_installation_2405 branch September 13, 2019 08:04
jcohenadad pushed a commit that referenced this pull request Dec 18, 2019
…n_2405

Modify bashrc on sudo

Former-commit-id: 531f38238e8e1b42ec4700c8987e7ece320a8b34 [formerly f739d1a [formerly 4bff9e3]]
Former-commit-id: 132a38f1ed299e6db17698747eb9fa7f342459e7
Former-commit-id: ce52e05
jcohenadad pushed a commit that referenced this pull request Dec 18, 2019
…n_2405

Modify bashrc on sudo

Former-commit-id: 4bff9e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation category: install_sct or pip/setup.py
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify bashrc for root installation
2 participants