Fixed bug that appeared when inputing uncompressed nifti file #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleygros
added
bug
jcohenadad
approved these changes
Mar 25, 2019
jcohenadad
changed the title
jcohenadad
pushed a commit
that referenced
this pull request
Dec 18, 2019
Fixed bug that appeared when inputing uncompressed nifti file Former-commit-id: 0b3d3c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at fixing the bug reported here.
scipy.measurements.center_of_massreceivesnp.arrayas input.The bug occurs when the input segmentation file is not compressed (ie .nii versus .nii.gz). In that case, the type of
seg.datais<class 'numpy.core.memmap.memmap'>.That's a known issue: #2148.
A solution is to cast
np.arraywhen callingseg.data.To test:
Fixes #2191.