Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function to analyze lesions #1351 #1439

Merged
merged 46 commits into from
Sep 13, 2017
Merged

Function to analyze lesions #1351 #1439

merged 46 commits into from
Sep 13, 2017

Conversation

charleygros
Copy link
Member

@charleygros charleygros commented Aug 21, 2017

Requirements

  • Does the pull request need an update of the documentation ?
    TODO in SourceForge?

Applicable Issues

Implements #1351

charleygros added 30 commits April 19, 2017 13:54
Angle correction
@@ -232,6 +232,8 @@ def _measure_volume(self, im_data, p_lst, idx):
printv(' Volume : ' + str(round(vol_tot_cur, 2)) + ' mm^3', self.verbose, type='info')

def _measure_length(self, im_data, p_lst, idx):
print len(self.angles)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these print statements required? If so, you can use sct_utils.printv instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed! Is it now correct?

@peristeri peristeri added feature category: new functionality fix:major and removed fix:major labels Sep 7, 2017
@peristeri
Copy link
Contributor

@charleygros was there a test file part of this pull request?

@peristeri
Copy link
Contributor

@benjamindeleener @jcohenadad @charleygros is the design discussion on analysing lesions completed?

Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have the time to test this function. Regarding the documentation: i would suggest to put something minimal in sourceforge, and in the near future we will move the whole doc in github.io using sphinx

@jcohenadad jcohenadad added this to the Release v3.0.8 milestone Sep 13, 2017
@jcohenadad jcohenadad merged commit 5b0cbe3 into master Sep 13, 2017
@jcohenadad jcohenadad deleted the cg_i1351 branch September 13, 2017 13:30
jcohenadad added a commit that referenced this pull request Sep 13, 2017
* jca-release:
  DOC: CHANGES: updated for 3.0.8
  Function to analyze lesions #1351 (#1439)
  BUG: propseg: added try/except for QC report (issue #1456) (#1457)
  Conversion issue for float32 images with large dynamic (#1450)
  Now possible to input single label at disc (instead of mid-body) (#1451)
  Various improvements (#1448)
  BUG: extract_metric: moved diagonalization for map and ml cases only (issue 1445) (#1446)
  Now using N-1 instead of N as denominator for computing the STD. (#1441)
  Updated the list of articles citing SCT. (#1437)
  Properly exit the installation process if error occurs
  DEV: fixed bug on centerline when referencing to the PMJ
jcohenadad added a commit that referenced this pull request Oct 9, 2017
* master: (31 commits)
  Introduced the zoom functionality to the anatomical canvas (#1477)
  Poq issue 1409 log (#1411)
  The minimal QT dialog  (#1379)
  Update README.md
  download_data: forgot to add pmj_models in the -d flag
  INST: added PMJ models to OSF
  Remove models
  Add models to data folder
  Update README.md
  DEV: outputs continuous pixel coordinates of centerline
  DEV: improvements and fixing bugs
  DEV: added option to select the gap between points
  NEW: function for generating a centerline using a few points on a viewer
  Documentation and Usage
  BUG: download_data: updated binaries to fix issue #1464 (#1465)
  BUG: image/keep-vol: wrong argument passed
  Function to analyze lesions #1351 (#1439)
  BUG: propseg: added try/except for QC report (issue #1456) (#1457)
  Conversion issue for float32 images with large dynamic (#1450)
  DEV: new method to get interpolated coordinate along centerline
  ...

# Conflicts:
#	scripts/sct_pipeline.py
#	scripts/sct_testing.py
#	testing/test_sct_propseg.py
jcohenadad added a commit that referenced this pull request Dec 18, 2019
* jca-release:
  DOC: CHANGES: updated for 3.0.8
  Function to analyze lesions #1351 (#1439)
  BUG: propseg: added try/except for QC report (issue #1456) (#1457)
  Conversion issue for float32 images with large dynamic (#1450)
  Now possible to input single label at disc (instead of mid-body) (#1451)
  Various improvements (#1448)
  BUG: extract_metric: moved diagonalization for map and ml cases only (issue 1445) (#1446)
  Now using N-1 instead of N as denominator for computing the STD. (#1441)
  Updated the list of articles citing SCT. (#1437)
  Properly exit the installation process if error occurs
  DEV: fixed bug on centerline when referencing to the PMJ


Former-commit-id: 16dd07d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature category: new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants