Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deployments-k8s#2393] Rework connect to per-request clients #1069

Merged
merged 5 commits into from
Sep 23, 2021
Merged

[deployments-k8s#2393] Rework connect to per-request clients #1069

merged 5 commits into from
Sep 23, 2021

Conversation

Bolodya1997
Copy link

Description

Reworks connect to use per-request clients.

Issue link

Closes networkservicemesh/deployments-k8s#2393.

How Has This Been Tested?

  • Added unit testing to cover Covered by existing unit testing
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin denis-tingaikin mentioned this pull request Aug 16, 2021
Open
@Bolodya1997 Bolodya1997 force-pushed the deployments-k8s#2393/rework-connect branch 29 times, most recently from 8e0c765 to 09a4629 Compare August 18, 2021 10:08
@edwarnicke
Copy link
Member

Thoughts on #1083 ?

@Bolodya1997 Bolodya1997 mentioned this pull request Sep 21, 2021
Merged
9 tasks
@Bolodya1997
Copy link
Author

Thoughts on #1083 ?

@edwarnicke
It looks great, but it doesn't solve existing issue with SVID rotation and mismatch between the token and the SSL certificates.
So we still need either to merge this PR and rebase your one, or just modify your PR if you don't want this one to be merged :)

Vladimir Popov added 5 commits September 23, 2021 17:01
Rework connect + heal to per-request clients
2a1c220 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Rework mechanismtranslation to metadata
2b0a9f9 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Remove resetting
fc008c5 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Reorder client chain
e760be1 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Fix tests
610af85 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997 Bolodya1997 force-pushed the deployments-k8s#2393/rework-connect branch from dd17e84 to 610af85 Compare September 23, 2021 10:03
denis-tingaikin
denis-tingaikin approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is required for networkservicemesh/deployments-k8s#2381

Connect client also will be reworked after in #1083

@denis-tingaikin denis-tingaikin merged commit a96ead9 into networkservicemesh:main Sep 23, 2021
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Sep 23, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
57e2c73 
…k@main

PR link: networkservicemesh/sdk#1069

Commit: a96ead9
Author: Vladimir Popov
Date: 2021-09-23 19:17:29 +0700
Message:
  - [deployments-k8s#2393] Rework connect to per-request clients (#1069)
* Rework connect + heal to per-request clients

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework mechanismtranslation to metadata

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Remove resetting

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Reorder client chain

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Sep 23, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
82181b8 
…k@main

PR link: networkservicemesh/sdk#1069

Commit: a96ead9
Author: Vladimir Popov
Date: 2021-09-23 19:17:29 +0700
Message:
  - [deployments-k8s#2393] Rework connect to per-request clients (#1069)
* Rework connect + heal to per-request clients

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework mechanismtranslation to metadata

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Remove resetting

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Reorder client chain

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Sep 23, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ad95999 
…k@main

PR link: networkservicemesh/sdk#1069

Commit: a96ead9
Author: Vladimir Popov
Date: 2021-09-23 19:17:29 +0700
Message:
  - [deployments-k8s#2393] Rework connect to per-request clients (#1069)
* Rework connect + heal to per-request clients

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework mechanismtranslation to metadata

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Remove resetting

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Reorder client chain

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Sep 23, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
20d3384 
…k@main

PR link: networkservicemesh/sdk#1069

Commit: a96ead9
Author: Vladimir Popov
Date: 2021-09-23 19:17:29 +0700
Message:
  - [deployments-k8s#2393] Rework connect to per-request clients (#1069)
* Rework connect + heal to per-request clients

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework mechanismtranslation to metadata

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Remove resetting

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Reorder client chain

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Sep 23, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
53b0afa 
…k@main

PR link: networkservicemesh/sdk#1069

Commit: a96ead9
Author: Vladimir Popov
Date: 2021-09-23 19:17:29 +0700
Message:
  - [deployments-k8s#2393] Rework connect to per-request clients (#1069)
* Rework connect + heal to per-request clients

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework mechanismtranslation to metadata

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Remove resetting

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Reorder client chain

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Sep 23, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
418d524 
…k@main

PR link: networkservicemesh/sdk#1069

Commit: a96ead9
Author: Vladimir Popov
Date: 2021-09-23 19:17:29 +0700
Message:
  - [deployments-k8s#2393] Rework connect to per-request clients (#1069)
* Rework connect + heal to per-request clients

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework mechanismtranslation to metadata

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Remove resetting

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Reorder client chain

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Sep 23, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
71377c4 
…k@main

PR link: networkservicemesh/sdk#1069

Commit: a96ead9
Author: Vladimir Popov
Date: 2021-09-23 19:17:29 +0700
Message:
  - [deployments-k8s#2393] Rework connect to per-request clients (#1069)
* Rework connect + heal to per-request clients

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Rework mechanismtranslation to metadata

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Remove resetting

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Reorder client chain

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Fix tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 23, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Bolodya1997 Bolodya1997 mentioned this pull request Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@glazychev-art glazychev-art Awaiting requested review from glazychev-art

@Mixaster995 Mixaster995 Awaiting requested review from Mixaster995

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

Assignees

@Bolodya1997 Bolodya1997

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NSM Connection fails if spire-agent restarts on NSC node
3 participants
@Bolodya1997 @edwarnicke @denis-tingaikin