Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk#1042] Fix monitor blocking sending events on non-reading client #1066

Merged
merged 1 commit into from
Aug 17, 2021
Merged

[sdk#1042] Fix monitor blocking sending events on non-reading client #1066

merged 1 commit into from
Aug 17, 2021

Conversation

Bolodya1997
Copy link

Description

Creates separate executors for sending events to different monitor clients.

Issue link

Closes #1042.

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@Bolodya1997 Bolodya1997 marked this pull request as draft August 16, 2021 05:48
Fix monitor blocking sending events on non-reading client
ec80841 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997 Bolodya1997 marked this pull request as ready for review August 16, 2021 06:00
denis-tingaikin
denis-tingaikin approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denis-tingaikin denis-tingaikin merged commit 9dc78f7 into networkservicemesh:main Aug 17, 2021
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Aug 17, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
142e5f2 
…k@main

PR link: networkservicemesh/sdk#1066

Commit: 9dc78f7
Author: Vladimir Popov
Date: 2021-08-17 20:21:18 +0700
Message:
  - Fix monitor blocking sending events on non-reading client (#1066)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Aug 17, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1fa1331 
…k@main

PR link: networkservicemesh/sdk#1066

Commit: 9dc78f7
Author: Vladimir Popov
Date: 2021-08-17 20:21:18 +0700
Message:
  - Fix monitor blocking sending events on non-reading client (#1066)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Aug 17, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
25c1055 
…k@main

PR link: networkservicemesh/sdk#1066

Commit: 9dc78f7
Author: Vladimir Popov
Date: 2021-08-17 20:21:18 +0700
Message:
  - Fix monitor blocking sending events on non-reading client (#1066)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Aug 17, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f89d735 
…k@main

PR link: networkservicemesh/sdk#1066

Commit: 9dc78f7
Author: Vladimir Popov
Date: 2021-08-17 20:21:18 +0700
Message:
  - Fix monitor blocking sending events on non-reading client (#1066)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Aug 17, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2e88048 
…k@main

PR link: networkservicemesh/sdk#1066

Commit: 9dc78f7
Author: Vladimir Popov
Date: 2021-08-17 20:21:18 +0700
Message:
  - Fix monitor blocking sending events on non-reading client (#1066)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Aug 17, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2ef65d6 
…k@main

PR link: networkservicemesh/sdk#1066

Commit: 9dc78f7
Author: Vladimir Popov
Date: 2021-08-17 20:21:18 +0700
Message:
  - Fix monitor blocking sending events on non-reading client (#1066)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Aug 17, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
00d513a 
…k@main

PR link: networkservicemesh/sdk#1066

Commit: 9dc78f7
Author: Vladimir Popov
Date: 2021-08-17 20:21:18 +0700
Message:
  - Fix monitor blocking sending events on non-reading client (#1066)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Aug 17, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
79f263c 
…k@main

PR link: networkservicemesh/sdk#1066

Commit: 9dc78f7
Author: Vladimir Popov
Date: 2021-08-17 20:21:18 +0700
Message:
  - Fix monitor blocking sending events on non-reading client (#1066)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Aug 17, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
aac5f01 
…k@main

PR link: networkservicemesh/sdk#1066

Commit: 9dc78f7
Author: Vladimir Popov
Date: 2021-08-17 20:21:18 +0700
Message:
  - Fix monitor blocking sending events on non-reading client (#1066)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 17, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@glazychev-art glazychev-art Awaiting requested review from glazychev-art

@Mixaster995 Mixaster995 Awaiting requested review from Mixaster995

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Monitor server can block on sending an event
2 participants
@Bolodya1997 @denis-tingaikin