Formatting change for NSMBot PR message #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Bolodya1997
approved these changes
Jul 26, 2021
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Mixaster995
force-pushed
the
fix/nsm-bot-pr-message
branch
2 times, most recently
from
025befd
to
edddc8f
Compare
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Mixaster995
force-pushed
the
fix/nsm-bot-pr-message
branch
2 times, most recently
from
7848fed
to
42308eb
Compare
Mixaster995
force-pushed
the
fix/nsm-bot-pr-message
branch
from
42308eb
to
4cd7d9f
Compare
Bolodya1997
approved these changes
Jul 30, 2021
|
@Mixaster995 Is this ready to merge? |
@edwarnicke If you are OK with these changes, probably we want to wait for some time and add PRs to all other repositories to merge them in the same time. |
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Mixaster995
force-pushed
the
fix/nsm-bot-pr-message
branch
from
4cd7d9f
to
ff70d65
Compare
denis-tingaikin
approved these changes
Aug 8, 2021
There was a problem hiding this comment.
Looks good.
@Mixaster995 Please apply this for all other repos.
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Aug 8, 2021
…k@main PR link: networkservicemesh/sdk#1041 Commit: d5aa809 Author: Авраменко Михаил Date: 2021-08-08 19:13:33 +0700 Message: - Formatting change for NSMBot PR message (#1041) * added multiline PR comment Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * reduced excessive repetitions, made short hash Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed message formatting Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * fix for retrieving pr number Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Aug 8, 2021
…k@main PR link: networkservicemesh/sdk#1041 Commit: d5aa809 Author: Авраменко Михаил Date: 2021-08-08 19:13:33 +0700 Message: - Formatting change for NSMBot PR message (#1041) * added multiline PR comment Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * reduced excessive repetitions, made short hash Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed message formatting Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * fix for retrieving pr number Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Aug 8, 2021
…k@main PR link: networkservicemesh/sdk#1041 Commit: d5aa809 Author: Авраменко Михаил Date: 2021-08-08 19:13:33 +0700 Message: - Formatting change for NSMBot PR message (#1041) * added multiline PR comment Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * reduced excessive repetitions, made short hash Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed message formatting Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * fix for retrieving pr number Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Aug 8, 2021
…k@main PR link: networkservicemesh/sdk#1041 Commit: d5aa809 Author: Авраменко Михаил Date: 2021-08-08 19:13:33 +0700 Message: - Formatting change for NSMBot PR message (#1041) * added multiline PR comment Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * reduced excessive repetitions, made short hash Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed message formatting Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * fix for retrieving pr number Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Aug 8, 2021
…k@main PR link: networkservicemesh/sdk#1041 Commit: d5aa809 Author: Авраменко Михаил Date: 2021-08-08 19:13:33 +0700 Message: - Formatting change for NSMBot PR message (#1041) * added multiline PR comment Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * reduced excessive repetitions, made short hash Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed message formatting Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * fix for retrieving pr number Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Aug 8, 2021
…k@main PR link: networkservicemesh/sdk#1041 Commit: d5aa809 Author: Авраменко Михаил Date: 2021-08-08 19:13:33 +0700 Message: - Formatting change for NSMBot PR message (#1041) * added multiline PR comment Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * reduced excessive repetitions, made short hash Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed message formatting Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * fix for retrieving pr number Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Aug 8, 2021
…k@main PR link: networkservicemesh/sdk#1041 Commit: d5aa809 Author: Авраменко Михаил Date: 2021-08-08 19:13:33 +0700 Message: - Formatting change for NSMBot PR message (#1041) * added multiline PR comment Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * reduced excessive repetitions, made short hash Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed message formatting Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * fix for retrieving pr number Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Aug 8, 2021
…k@main PR link: networkservicemesh/sdk#1041 Commit: d5aa809 Author: Авраменко Михаил Date: 2021-08-08 19:13:33 +0700 Message: - Formatting change for NSMBot PR message (#1041) * added multiline PR comment Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * reduced excessive repetitions, made short hash Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed message formatting Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * fix for retrieving pr number Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Aug 8, 2021
…k@main PR link: networkservicemesh/sdk#1041 Commit: d5aa809 Author: Авраменко Михаил Date: 2021-08-08 19:13:33 +0700 Message: - Formatting change for NSMBot PR message (#1041) * added multiline PR comment Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * reduced excessive repetitions, made short hash Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed message formatting Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * fix for retrieving pr number Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 8, 2021
| - name: Get sha | ||
| id: get-sha | ||
| run: | | ||
| echo ::set-output name=sha::$( curl -u "u:${{secrets.NSM_BOT_GITHUB_TOKEN}}" https://github.com/gitapi/repos/networkservicemesh/sdk/git/ref/heads/main | jq .object.sha | tr -d '"' ) |
There was a problem hiding this comment.
Please use GITHUB_SHA env. or for context ${{github.sha}}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikhail Avramenko avramenkomihail15@gmail.com
Description
First step to make NSMBot messages more human-readable
Issue link
networkservicemesh/cmd-template#64
How Has This Been Tested?
Types of changes