NETOBSERV-722: decorate node flows with actual node IP and name fields #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
added
the
ok-to-test
|
New image: ["quay.io/netobserv/flowlogs-pipeline:d1a58f1"]. It will expire after two weeks. |
Codecov Report
@@ Coverage Diff @@
## main #354 +/- ##
==========================================
- Coverage 68.86% 68.80% -0.07%
==========================================
Files 87 87
Lines 5101 5109 +8
==========================================
+ Hits 3513 3515 +2
- Misses 1369 1376 +7
+ Partials 219 218 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
KalmanMeth
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, when you filter flows in the console by Node IP, you will get both Pod and Node flows (Before we were only getting Pod flows, as Node flows were decorated with Src/Dst address but not with Src/Dst Node IP).