Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log as debug: "Can't find service name for..." #295

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 6, 2022

Currently, FLP logs show loads of these "Can't find service name for Port 57430 and protocol 6" logs
Problem is that they don't really refer to issues, it's totally expected to have unmatched ports (especially when looking at source ports). The fact that this is logged within the processing pipeline loop make them unsuitable for Info level.
This PR moves them to Debug level.

@jotak
Copy link
Member Author

jotak commented Sep 6, 2022

Also removes err from the second log, as it's always nil

@jotak
Copy link
Member Author

jotak commented Sep 6, 2022

Also, if we want another strategy for reporting this kind of things that are generated in the pipeline loop, using metrics could be a better alternative than logging.

@codecov-commenter
Copy link

Codecov Report

Merging #295 (06b9f2a) into main (5f8bf5f) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   67.70%   67.70%           
=======================================
  Files          74       74           
  Lines        4357     4357           
=======================================
  Hits         2950     2950           
  Misses       1219     1219           
  Partials      188      188           
Flag Coverage Δ
unittests 67.70% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/transform/transform_network.go 61.84% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jotak jotak merged commit b6ab1b0 into netobserv:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants