conntrack: Remove old implementation #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronensc
force-pushed
the
conntrack-remove-old
branch
from
5a30ee3
to
1c0697b
Compare
KalmanMeth
reviewed
Sep 1, 2022
| - input: "{{.srcIP}},{{.srcPort}},{{.dstIP}},{{.dstPort}},{{.protocol}}" | ||
| output: isNewFlow | ||
| type: conn_tracking | ||
| parameters: "1" | ||
| ``` | ||
|
|
||
| The first rule `add_subnet` generates a new field named `srcSubnet` with the |
There was a problem hiding this comment.
Will there be a new section on describing the connection tracking parameters?
There was a problem hiding this comment.
I documented the new connection tracking in #291
KalmanMeth
approved these changes
Sep 1, 2022
ronensc
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old implementation of the connection tracking and migrates the metric that used it
connection rate per dest subnetto rely on the new implementation.