Added assign_if transformation #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
==========================================
+ Coverage 66.83% 66.85% +0.01%
==========================================
Files 73 73
Lines 4149 4160 +11
==========================================
+ Hits 2773 2781 +8
- Misses 1197 1199 +2
- Partials 179 180 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
KalmanMeth
reviewed
Aug 2, 2022
| @@ -95,6 +95,18 @@ func (n *Network) TransformEntry(inputEntry config.GenericMap) config.GenericMap | |||
| outputEntry[rule.Output] = outputEntry[rule.Input] | |||
| outputEntry[rule.Output+"_Evaluate"] = true | |||
| } | |||
| case api.TransformNetworkOperationName("AssignIf"): | |||
| expressionString := fmt.Sprintf("val %s", rule.Parameters) | |||
There was a problem hiding this comment.
Eran asked to combine the AssignIf into the existing AddIf. The code is essentially the same, with the exception of what gets assigned to the the Output variable. If an assigned value is provided, it gets the new value; otherwise it gets the value of the Input variable.
Fixes netobserv#275 Signed-off-by: Kuldeep Singh Pal <tkuldeep.allen@gmail.com>
eranra
approved these changes
Aug 2, 2022
KalmanMeth
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #275
Signed-off-by: Kuldeep Singh Pal tkuldeep.allen@gmail.com