Add to Transform Filter to support remove_entry_if_equal and remove_entry_if_not_equal #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #273 +/- ##
==========================================
+ Coverage 66.83% 66.96% +0.12%
==========================================
Files 73 73
Lines 4149 4159 +10
==========================================
+ Hits 2773 2785 +12
+ Misses 1197 1194 -3
- Partials 179 180 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
ronensc
approved these changes
Aug 9, 2022
| Type string `yaml:"type,omitempty" json:"type,omitempty" enum:"TransformFilterOperationEnum" doc:"one of the following:"` | ||
| Input string `yaml:"input,omitempty" json:"input,omitempty" doc:"entry input field"` | ||
| Type string `yaml:"type,omitempty" json:"type,omitempty" enum:"TransformFilterOperationEnum" doc:"one of the following:"` | ||
| Value interface{} `yaml:"value,omitempty" json:"value,omitempty" enum:"TransformFilterOperationEnum" doc:"specified value of input field:"` |
There was a problem hiding this comment.
I think that the enum:"TransformFilterOperationEnum" tag of Value is redundant. If so, then docs/api.md should be updated as well.
There was a problem hiding this comment.
The Value is needed to specify the equal / not_equal to match the key supplied in Input to decide whether to remove flow entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to Transform Filter the ability to filter out flow logs based on whether a certain field is equal or not equal to some value.
This functionality is needed by Palmetto to filter out flow logs that do or do not satisfy some condition (such as direction of the flow).