adjustments to confgenerator for Operator #251
Conversation
KalmanMeth
changed the title
Codecov Report
@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 61.63% 60.32% -1.32%
==========================================
Files 67 67
Lines 3915 3997 +82
==========================================
- Hits 2413 2411 -2
- Misses 1350 1435 +85
+ Partials 152 151 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| parameters[i] = map[string]interface{}{ | ||
| "name": "ingest_collector", | ||
| "ingest": map[string]interface{}{ | ||
| "type": "collector", | ||
| "collector": map[string]interface{}{ | ||
| "port": cg.config.Ingest.Collector.Port, | ||
| "portLegacy": cg.config.Ingest.Collector.PortLegacy, | ||
| "hostname": cg.config.Ingest.Collector.HostName, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I think we now have all these data structures defined in https://github.com/netobserv/flowlogs-pipeline/tree/main/pkg/api
Maybe we should consider reusing them rather than having them repeated here?
There was a problem hiding this comment.
The high-level of StageParam is defined in a different file:
flowlogs-pipeline/pkg/config/config.go
Lines 48 to 55 in 467e409
And perhaps the pipeline config builder could become handy
https://github.com/netobserv/flowlogs-pipeline/blob/main/pkg/config/pipeline_builder.go
There was a problem hiding this comment.
If we want to redo this, let's put it in a separate issue and PR.
There was a problem hiding this comment.
I created an issue for this
#254
Include only extract-aggregate and encode-prom rules in the produced config file.