Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tabulated output to write_stdout #231

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Add tabulated output to write_stdout #231

merged 3 commits into from
Jul 13, 2022

Conversation

amorenoz
Copy link
Contributor

Add a new format to write_stdout module called fields that can be used to print tabulated output which is slightly easier to read than raw json or text outputs.

ronensc
ronensc requested changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@ronensc ronensc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make docs to update the docs.

@amorenoz
Copy link
Contributor Author

Sure, will do. Thanks

@amorenoz amorenoz force-pushed the tabulated-write branch 2 times, most recently from 68d603e to f89eb4a Compare June 20, 2022 09:19
@amorenoz
write_stdout: add tabulated data format
2593b9e 
Add a new write_stdout format called "fields". If specified, write a
tabulated list of fields. It's easier to read than raw json or text
outputs.

Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
@KalmanMeth
Copy link
Collaborator

After running make docs add the updated doc to the PR.

@amorenoz
Copy link
Contributor Author

After running make docs add the updated doc to the PR.

I have, haven't I?
https://github.com/netobserv/flowlogs-pipeline/pull/231/files#diff-9eddf4dc51bf6a0125ca7fb094468ad284112270385c41cebce4f8f0a29620ab

@KalmanMeth
Copy link
Collaborator

Please add an example in the docs (perhaps in the README.md) on how to use this new fields feature.

jotak
jotak reviewed Jul 7, 2022
View reviewed changes
docs/api.md Outdated Show resolved Hide resolved
pkg/api/write_stdout.go Outdated Show resolved Hide resolved
@jotak jotak merged commit 65b11c5 into netobserv:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotak jotak jotak left review comments

@ronensc ronensc ronensc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amorenoz @KalmanMeth @jotak @ronensc