-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made encode a terminal stage #194
Conversation
Codecov Report
@@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 58.25% 58.31% +0.05%
==========================================
Files 58 58
Lines 3349 3351 +2
==========================================
+ Hits 1951 1954 +3
+ Misses 1269 1267 -2
- Partials 129 130 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Temporarily setting do-not-merge label since this is a breaking change that can break existing installations and RC release. Let me work on a temporary solution to keep NOO working after we merge this change. |
Please let's coordinate merging this PR at the same time as: netobserv/network-observability-operator#93 |
Unblocking the PR, after internally discussing and make sure that this won't break the next NOO release. |
@mariomac Mario, Please merge this PR at the same time you perform the merge on https://github.com/netobserv/network-observability-operator/pull/93 |
Made encode_prom (and other encode stages) into a terminal stage.
We then do not need to add write_none as a dummy terminal stage.