Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made encode a terminal stage #194

Merged
merged 3 commits into from
May 4, 2022
Merged

Conversation

KalmanMeth
Copy link
Collaborator

Made encode_prom (and other encode stages) into a terminal stage.
We then do not need to add write_none as a dummy terminal stage.

@KalmanMeth KalmanMeth linked an issue Apr 28, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #194 (c71e9ed) into main (f13dc86) will increase coverage by 0.05%.
The diff coverage is 86.20%.

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   58.25%   58.31%   +0.05%     
==========================================
  Files          58       58              
  Lines        3349     3351       +2     
==========================================
+ Hits         1951     1954       +3     
+ Misses       1269     1267       -2     
- Partials      129      130       +1     
Flag Coverage Δ
unittests 58.31% <86.20%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/confgen/flowlogs2metrics_config.go 0.00% <ø> (ø)
pkg/pipeline/pipeline_builder.go 59.50% <20.00%> (-0.43%) ⬇️
pkg/pipeline/encode/encode.go 100.00% <100.00%> (ø)
pkg/pipeline/encode/encode_kafka.go 66.66% <100.00%> (-1.13%) ⬇️
pkg/pipeline/encode/encode_prom.go 81.77% <100.00%> (+0.08%) ⬆️
pkg/confgen/grafana_jsonnet.go 0.00% <0.00%> (ø)
pkg/pipeline/ingest/ingest_collector.go 65.28% <0.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13dc86...c71e9ed. Read the comment docs.

@mariomac
Copy link

mariomac commented May 2, 2022

Temporarily setting do-not-merge label since this is a breaking change that can break existing installations and RC release.

Let me work on a temporary solution to keep NOO working after we merge this change.

@mariomac
Copy link

mariomac commented May 2, 2022

Please let's coordinate merging this PR at the same time as: netobserv/network-observability-operator#93

@mariomac
Copy link

mariomac commented May 2, 2022

Unblocking the PR, after internally discussing and make sure that this won't break the next NOO release.

@KalmanMeth
Copy link
Collaborator Author

@mariomac Mario, Please merge this PR at the same time you perform the merge on https://github.com/netobserv/network-observability-operator/pull/93

@mariomac mariomac merged commit fdd8ca2 into netobserv:main May 4, 2022
@KalmanMeth KalmanMeth deleted the prom-final branch May 24, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Prometheus stage to be a finalizing stage
3 participants