add support for deleting expired aggregates #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranra
force-pushed
the
126_clean_aggregates
branch
from
5cc400c
to
c4cef02
Compare
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 57.86% 58.48% +0.61%
==========================================
Files 58 58
Lines 3318 3365 +47
==========================================
+ Hits 1920 1968 +48
+ Misses 1270 1268 -2
- Partials 128 129 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
KalmanMeth
approved these changes
Apr 11, 2022
ronensc
reviewed
Apr 12, 2022
eranra
force-pushed
the
126_clean_aggregates
branch
from
c4cef02
to
cc924c7
Compare
eranra
force-pushed
the
126_clean_aggregates
branch
from
cc924c7
to
77ea806
Compare
ronensc
reviewed
Apr 14, 2022
Comment on lines
+95
to
+97
| aggregate.mutex.Lock() | ||
| aggregate.cleanupExpiredEntries() | ||
| aggregate.mutex.Unlock() |
There was a problem hiding this comment.
I think it's better to move the Lock()/Unlock() inside aggregate.cleanupExpiredEntries() as done in GetMetrics() and UpdateByEntry()
Comment on lines
+72
to
+75
| time.Sleep(2 * time.Second) // still exists after 2 seconds | ||
| require.Equal(t, 1, len(aggregates.Aggregates[0].GetMetrics())) | ||
| time.Sleep(3 * time.Second) // expires after 3 more seconds (5 seconds in total) | ||
| require.Equal(t, 0, len(aggregates.Aggregates[0].GetMetrics())) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.