-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add raw values operation #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ... no comments ... only request is to add also documentation in README so that it is well understood that choosing raw_values
is different from the rest of the operations and that the values are added to the "recent raw values" field and not to the regular recent op value ... also give some explanation why this is needed.
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 58.46% 58.72% +0.26%
==========================================
Files 51 54 +3
Lines 2949 3084 +135
==========================================
+ Hits 1724 1811 +87
- Misses 1113 1152 +39
- Partials 112 121 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
65ffcd6
to
4544452
Compare
@KalmanMeth @eranra Please pay attention to the added documentation. Is it clear enough? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor updates to doc .... looks good to me. LGTM
No description provided.