Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw values operation #152

Merged
merged 16 commits into from
Apr 3, 2022
Merged

Conversation

ronensc
Copy link
Collaborator

@ronensc ronensc commented Mar 24, 2022

No description provided.

@ronensc ronensc mentioned this pull request Mar 24, 2022
Copy link
Collaborator

@eranra eranra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ... no comments ... only request is to add also documentation in README so that it is well understood that choosing raw_values is different from the rest of the operations and that the values are added to the "recent raw values" field and not to the regular recent op value ... also give some explanation why this is needed.

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #152 (d5cfdbf) into main (6668d30) will increase coverage by 0.26%.
The diff coverage is 63.26%.

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   58.46%   58.72%   +0.26%     
==========================================
  Files          51       54       +3     
  Lines        2949     3084     +135     
==========================================
+ Hits         1724     1811      +87     
- Misses       1113     1152      +39     
- Partials      112      121       +9     
Flag Coverage Δ
unittests 58.72% <63.26%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/utils/convert.go 18.18% <18.18%> (ø)
pkg/pipeline/encode/encode_prom.go 81.85% <59.09%> (+0.77%) ⬆️
pkg/pipeline/extract/aggregate/aggregate.go 95.08% <100.00%> (+0.21%) ⬆️
pkg/test/utils.go 82.22% <100.00%> (-0.20%) ⬇️
pkg/config/config.go 50.00% <0.00%> (ø)
pkg/pipeline/write/write_stdout.go 100.00% <0.00%> (ø)
pkg/pipeline/ingest/ingest_kafka.go 85.85% <0.00%> (ø)
pkg/pipeline/decode/decode_protobuf.go 74.54% <0.00%> (ø)
pkg/pipeline/ingest/ingest_grpc.go 61.53% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6668d30...d5cfdbf. Read the comment docs.

@ronensc
Copy link
Collaborator Author

ronensc commented Mar 30, 2022

@KalmanMeth @eranra Please pay attention to the added documentation. Is it clear enough?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@eranra eranra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor updates to doc .... looks good to me. LGTM

@ronensc ronensc merged commit 6e05f32 into netobserv:main Apr 3, 2022
@ronensc ronensc deleted the add-raw-values-operation branch April 3, 2022 07:31
@ronensc ronensc linked an issue Apr 26, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nop operation to aggregate
3 participants