Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash FLP on an incorrect config file #274

Closed
ronensc opened this issue Aug 2, 2022 · 0 comments · Fixed by #279
Closed

Crash FLP on an incorrect config file #274

ronensc opened this issue Aug 2, 2022 · 0 comments · Fixed by #279

Comments

@ronensc
Copy link
Collaborator

ronensc commented Aug 2, 2022

Currently, FLP will start normally even if its config has unknown fields.
The problem is that misspelled fields will silently be ignored and have default values.
It's better to crash FLP with an indicative error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make unmarshaling json config strict ronensc/flowlogs-pipeline
1 participant
@ronensc