-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse API data structures in confgen #254
Comments
jotak
added a commit
to jotak/flowlogs-pipeline
that referenced
this issue
Jul 25, 2022
Fixes netobserv#254 - Removed duplicated confgen model - Use PipelineBuilder to simplify pipeline generation - Make confgen easier to consume as a lib (e.g. for NOO) - Do not make it necessary to call "Run": parsing definition files should be sufficient - Do not make it necessary to work with files written on disk: work with []byte instead - SkipWithTags should not result in an error when a file is skipped - Add confgen tests
jotak
added a commit
to jotak/flowlogs-pipeline
that referenced
this issue
Jul 26, 2022
Fixes netobserv#254 - Removed duplicated confgen model - Use PipelineBuilder to simplify pipeline generation - Make confgen easier to consume as a lib (e.g. for NOO) - Do not make it necessary to call "Run": parsing definition files should be sufficient - Do not make it necessary to work with files written on disk: work with []byte instead - SkipWithTags should not result in an error when a file is skipped - Add confgen tests
jotak
added a commit
to jotak/flowlogs-pipeline
that referenced
this issue
Jul 26, 2022
Fixes netobserv#254 - Removed duplicated confgen model - Use PipelineBuilder to simplify pipeline generation - Make confgen easier to consume as a lib (e.g. for NOO) - Do not make it necessary to call "Run": parsing definition files should be sufficient - Do not make it necessary to work with files written on disk: work with []byte instead - SkipWithTags should not result in an error when a file is skipped - Add confgen tests
This was
linked to
pull requests
Jul 28, 2022
Closed
Merged
jotak
added a commit
to jotak/flowlogs-pipeline
that referenced
this issue
Jul 29, 2022
Fixes netobserv#254 - Removed duplicated confgen model - Use PipelineBuilder to simplify pipeline generation - Make confgen easier to consume as a lib (e.g. for NOO) - Do not make it necessary to call "Run": parsing definition files should be sufficient - Do not make it necessary to work with files written on disk: work with []byte instead - SkipWithTags should not result in an error when a file is skipped - Add confgen tests
jotak
added a commit
that referenced
this issue
Jul 29, 2022
* Confgen: init from options (avoid many globals) * Use main model in confgen, use pipeline builder Fixes #254 - Removed duplicated confgen model - Use PipelineBuilder to simplify pipeline generation - Make confgen easier to consume as a lib (e.g. for NOO) - Do not make it necessary to call "Run": parsing definition files should be sufficient - Do not make it necessary to work with files written on disk: work with []byte instead - SkipWithTags should not result in an error when a file is skipped - Add confgen tests * Avoid using globals A side-effect of removing globals in write_loki is that it changes how the config is read, and set with defaults. Instead of unmarshaling a second time to automatically get defaults, we now call an explicit function that sets the default. Also, now removing loki URL default, it now has to be set explicitely * Update ConnTrack builder * More defer cleanup in tests, and use ioutils / temp dir/files Also fixed jsonnet dir actually used as filename prefix rather than directory * User ConfigFileStruct in confgen * Update pkg/config/config.go Co-authored-by: Ronen Schaffer <ronen.schaffer@ibm.com> * Use config.ConfigFileStruct in tests Co-authored-by: Ronen Schaffer <ronen.schaffer@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The config created by
confgen
is generated from nestedmap[string]interface{}
rather than reusing the structs defined in api and configflowlogs-pipeline/pkg/confgen/flowlogs2metrics_config.go
Lines 28 to 176 in ba91570
The pipeline config builder could also become handy
https://github.com/netobserv/flowlogs-pipeline/blob/main/pkg/config/pipeline_builder.go
The text was updated successfully, but these errors were encountered: