Make yaml.Unmarshal strict (#271)

* Make yaml.Unmarshal strict and fix test * Fix another test
netobserv · Aug 2, 2022 · 0184936 · 0184936
1 parent 6c1dae1
commit 0184936
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/pkg/api/utils_test.go b/pkg/api/utils_test.go
@@ -37,6 +37,6 @@ func TestDuration_MarshalYAML(t *testing.T) {
 func TestDuration_UnmarshalYAML(t *testing.T) {
 	expectedMsg := testMessage{Elapsed: Duration{2 * time.Hour}}
 	var actualMsg testMessage
-	require.NoError(t, yaml.Unmarshal([]byte("elapsed: 2h\n"), &actualMsg))
+	require.NoError(t, yaml.UnmarshalStrict([]byte("elapsed: 2h\n"), &actualMsg))
 	require.Equal(t, expectedMsg, actualMsg)
 }
diff --git a/pkg/confgen/confgen_test.go b/pkg/confgen/confgen_test.go
@@ -55,7 +55,6 @@ encode:
     prefix: flp_
     port: 9102
 visualization:
-  type: grafana
   grafana:
     dashboards:
       - name: "details"
@@ -90,7 +89,6 @@ write:
     staticLabels:
       job: flowlogs-pipeline
 visualization:
-  type: grafana
   grafana:
     dashboards:
       - name: "details"
@@ -107,7 +105,7 @@ details:
   test details
 usage:
   test usage
-labels:
+tags:
   - test
   - label
 transform:

diff --git a/pkg/confgen/config.go b/pkg/confgen/config.go
@@ -65,7 +65,7 @@ func (cg *ConfGen) ParseConfigFile(fileName string) (*Config, error) {
 		log.Debugf("ioutil.ReadFile err: %v ", err)
 		return nil, err
 	}
-	err = yaml.Unmarshal(yamlFile, &config)
+	err = yaml.UnmarshalStrict(yamlFile, &config)
 	if err != nil {
 		log.Debugf("Unmarshal err: %v ", err)
 		return nil, err