Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #215, Convert syslog writes during initialization to events #216

Merged

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

  • Fixes Syslog writes during initialization could be converted to events #215
    • Error/failures paths during initialization (after EVS registration) have been converted to generate events instead of syslog writes.
    • These are standard 'set-up' calls and will likely remain in adaptations of the sample app. Also, this is the standard pattern in the rest of cFS.

Testing performed
GitHub CI actions all passing successfully and tested locally with cFS suite to confirm events text formatted correctly etc.

Expected behavior changes
Errors during initialization (after EVS registration) will generate events now, rather than syslog writes.

System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

@thnkslprpt
Copy link
Contributor Author

The error paths in ProcessCmd and GetCrc should probably also be converted to events - happy to add those in to this PR before this is merged - just let me know.

@dzbaker dzbaker added the CCB:Approved Indicates code approval by CCB label Mar 21, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Mar 21, 2024
*Combines:*

cFE equuleus-rc1+dev114
sample_app equuleus-rc1+dev46

**Includes:**

*cFE*
- nasa/cFE#2387
- nasa/cFE#2531

*sample_app*
- nasa/sample_app#218
- nasa/sample_app#216

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
@dzbaker dzbaker merged commit 7b62604 into nasa:main Mar 21, 2024
11 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Mar 21, 2024
*Combines:*

cFE equuleus-rc1+dev114
sample_app equuleus-rc1+dev46

**Includes:**

*cFE*
- nasa/cFE#2387
- nasa/cFE#2531

*sample_app*
- nasa/sample_app#218
- nasa/sample_app#216

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
@thnkslprpt thnkslprpt deleted the fix-215-convert-init-syslog-writes-to-events branch March 22, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syslog writes during initialization could be converted to events
2 participants