From b9a76972b45d4344ed3cff008251d08ee293f978 Mon Sep 17 00:00:00 2001 From: Jacob Hageman Date: Tue, 9 Feb 2021 16:17:13 -0500 Subject: [PATCH] Fix #783, Initialize locals flagged in static analysis --- src/os/shared/src/osapi-idmap.c | 2 +- src/unit-tests/osfile-test/ut_osfile_dirio_test.c | 4 ++-- src/ut-stubs/osapi-utstub-bsp.c | 2 +- src/ut-stubs/osapi-utstub-idmap.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/os/shared/src/osapi-idmap.c b/src/os/shared/src/osapi-idmap.c index a8fb26c4b..fe5fce966 100644 --- a/src/os/shared/src/osapi-idmap.c +++ b/src/os/shared/src/osapi-idmap.c @@ -631,7 +631,7 @@ int32 OS_ObjectIdFindNextFree(OS_object_token_t *token) { uint32 max_id; uint32 base_id; - uint32 local_id; + uint32 local_id = 0; uint32 serial; uint32 i; int32 return_code; diff --git a/src/unit-tests/osfile-test/ut_osfile_dirio_test.c b/src/unit-tests/osfile-test/ut_osfile_dirio_test.c index 974b808bc..40540e824 100644 --- a/src/unit-tests/osfile-test/ut_osfile_dirio_test.c +++ b/src/unit-tests/osfile-test/ut_osfile_dirio_test.c @@ -439,7 +439,7 @@ void UT_os_closedir_test() **--------------------------------------------------------------------------------*/ void UT_os_readdir_test() { - osal_id_t dirh; + osal_id_t dirh = OS_OBJECT_ID_UNDEFINED; const char *testDesc; strcpy(g_subdirNames[0], " "); @@ -566,7 +566,7 @@ void UT_os_readdir_test() **--------------------------------------------------------------------------------*/ void UT_os_rewinddir_test() { - osal_id_t dirh; + osal_id_t dirh = OS_OBJECT_ID_UNDEFINED; const char *testDesc; strcpy(g_subdirNames[0], " "); diff --git a/src/ut-stubs/osapi-utstub-bsp.c b/src/ut-stubs/osapi-utstub-bsp.c index 0b2acd90d..126b5bb7f 100644 --- a/src/ut-stubs/osapi-utstub-bsp.c +++ b/src/ut-stubs/osapi-utstub-bsp.c @@ -56,7 +56,7 @@ uint32 OS_BSP_GetArgC(void) ------------------------------------------------------------------*/ char *const *OS_BSP_GetArgV(void) { - void *buffer; + void *buffer = NULL; int32 status; status = UT_DEFAULT_IMPL(OS_BSP_GetArgV); diff --git a/src/ut-stubs/osapi-utstub-idmap.c b/src/ut-stubs/osapi-utstub-idmap.c index 4b2bd3992..53ee462d5 100644 --- a/src/ut-stubs/osapi-utstub-idmap.c +++ b/src/ut-stubs/osapi-utstub-idmap.c @@ -138,7 +138,7 @@ OS_common_record_t *OS_ObjectIdGlobalFromToken(const OS_object_token_t *token) { static OS_common_record_t fake_record; int32 status; - OS_common_record_t * recptr; + OS_common_record_t * recptr = &fake_record; status = UT_DEFAULT_IMPL(OS_ObjectIdGlobalFromToken); if (status == 0 &&