-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lengthen allowable unit test names #553
Comments
Make it 120 and submit a PR? |
That will solve my issue. I am still curious if there is reasoning behind the setting. If there is a reason, then setting it to 120 may be breaking that. If there is not a reason then, I'll do it for sure. |
Excellent. Thank you for the review. I will change both and PR. |
I cannot make the change because there is a conflict and we're entering a seesaw situation. Blame reveals there was already a change to Line 45 in 8cfd6fe
in #534 it changed from 128 to 64, also changed was this Line 79 in 8cfd6fe
ReportBuffer went from 128 to 144, but this is not Line 101 in 8cfd6fe
that was mentioned in this discussion. |
I was responsible for making some of those size tweaks, and the reason is that newer GCC versions (e.g. 9+) are very aggressive about warning even the slightest possibility of a string truncation, even where the code handles the truncation perfectly fine. Basically, the buffer has to get bigger at each step to accommodate the extra info added. Nonetheless, this is the main risk of extending what seems like an unrelated buffer size - if it is copied or Perhaps these should all be converted to |
Describe the bug
Not sure if it is a bug, but why is the TestName length based upon OS_MAX_API_NAME*2 in utglobal.h?
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Provide enough space for long (descriptive) test names.
Code snips
osal/ut_assert/src/utglobal.h
Line 53 in 8cfd6fe
System observed on:
Additional context
This is only an issue because I use long descriptive test names.
Reporter Info
Alan Gibson
GSFC, Code 587
The text was updated successfully, but these errors were encountered: